Fix extra_body silently dropped during load_component()#7421
Open
joaquinhuigomez wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix extra_body silently dropped during load_component()#7421joaquinhuigomez wants to merge 1 commit intomicrosoft:mainfrom
joaquinhuigomez wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
joaquinhuigomez
force-pushed
the
fix/extra-body-config-7418
branch
from
b4922f1 to
fe0bcf2
Compare
Add extra_body field to CreateArguments (TypedDict) and CreateArgumentsConfigModel (Pydantic) so that extra_body specified in JSON config is preserved through the _from_config() / _to_config() round-trip. Previously, extra_body worked when passed directly to the constructor but was silently discarded when loading via load_component() or AutoGen Studio JSON config. Fixes microsoft#7418
joaquinhuigomez
force-pushed
the
fix/extra-body-config-7418
branch
from
fe0bcf2 to
c43c9f0
Compare
Author
|
Friendly ping — any chance this could get a review? Happy to address feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7418 —
extra_bodyis silently dropped when loading OpenAI model client config viaload_component().The
CreateArgumentsTypedDict andCreateArgumentsConfigModelPydantic model both lacked anextra_bodyfield, so any provider-specific parameters (e.g.extra_body: {"reasoning": {"effort": "high"}}for o3) were stripped during config validation.This adds
extra_body: Optional[Dict[str, Any]]to both models and threads it through to the API call.